Photo Organizer

This is the bug tracker for Photo Organizer.

ID Task Type Severity Category  asc Summary Status Reported In
 106 Bug ReportCriticalBackend / Core Install creates wrong directory structure in repository Closed2.32a5 Task Description

When installing photo organizer 2.32a on a clean system (so not an upgrade) the driectory structure in the repository is set up wrong. The 0000x folders are not created in the v0000 folder, but next to the folder at the root of the repository.

Where the structure should be:

<path-to-repository>/photoorganizer
/v0000
/00000
/00001
/00002

it is created as

<path-to-repository>/photoorganizer
/v0000
/00000
/00001
/00002

 108 Bug ReportCriticalBackend / Core Registering a new user is broken Closed2.32b1 Task Description

Fresh install, I get the following error when creating a simple user (just filling in mandatory fields, the bold ones)

Warning: pg_query() [function.pg-query]: Query failed: ERROR: column "f" does not exist in /var/www/localhost/htdocs/po/register.php on line 176

Warning: pg_query() [function.pg-query]: Query failed: ERROR: current transaction is aborted, commands ignored until end of transaction block in /var/www/localhost/htdocs/po/register.php on line 199

Warning: pg_query() [function.pg-query]: Query failed: ERROR: current transaction is aborted, commands ignored until end of transaction block in /var/www/localhost/htdocs/po/register.php on line 206

Warning: pg_query() [function.pg-query]: Query failed: ERROR: current transaction is aborted, commands ignored until end of transaction block in /var/www/localhost/htdocs/po/register.php on line 213

Warning: pg_query() [function.pg-query]: Query failed: ERROR: current transaction is aborted, commands ignored until end of transaction block in /var/www/localhost/htdocs/po/register.php on line 221

Warning: pg_query() [function.pg-query]: Query failed: ERROR: current transaction is aborted, commands ignored until end of transaction block in /var/www/localhost/htdocs/po/register.php on line 227

Warning: pg_query() [function.pg-query]: Query failed: ERROR: current transaction is aborted, commands ignored until end of transaction block in /var/www/localhost/htdocs/po/register.php on line 231

Warning: pg_query() [function.pg-query]: Query failed: ERROR: current transaction is aborted, commands ignored until end of transaction block in /var/www/localhost/htdocs/po/register.php on line 235

Warning: Cannot modify header information - headers already sent by (output started at /var/www/localhost/htdocs/po/register.php:176) in /var/www/localhost/htdocs/po/register.php on line 251

Stange as it works fine with my version of 2.32a on another machine. Could this be a database issue?

 112 Bug ReportCriticalBackend / Core Bug in bulk update Closed2.32b1 Task Description

I tried to change the Author and Copyright fields of all photos of a user.

Bulk update doesn't update the fields, it give the following result:

# author = 'Bjorn Dejonghe', copyright = 'Copyright (c) 2006 Bjorn Dejonghe'
# users = 6

Warning: pg_query() [function.pg-query]: Query failed: ERROR: column "copyright" of relation "photo" does not exist in /var/www/localhost/htdocs/po/bulk.update.php on line 261

Updated 602 photos.

 466 Bug ReportCriticalBackend / Core Original photos deleted without adding to database on d ...Closed2.371 Task Description

Hello,

I'm having a problem with writing to my database, but reads are fine. I am adding images from a local directory. I am using PO 2.36.1.

When I try to add images, I get red text telling me that the transferring the metadata failed and that PO failed to update the database. Unfortunately, PO still goes ahead with "cleaning up the mess".

Luckily I still have a backup of my photos, but this part of the process could probably use some extra checks and an abort before deleting the files.

Thank you,

Jeff

 18 Bug ReportHighBackend / Core Stop using predictable filenames ClosedDevel4 Task Description

For things like photo imports, exports, and whatnot, we use predictable sequences in our filenames. These should be properly randomized.

 113 Bug ReportHighBackend / Core camera edit doesn't respect owner ClosedStable7 Task Description

someone can edit a camera they don't own.

 158 Bug ReportHighBackend / Core AND in search for keywords does not work ClosedStable3 Task Description

Searching for 2 keywords linked with AND always gives back an empty result.
Eg.: I have 2 images that both have the keywords "abstract" and "art" attached to them. They can't be found by the search "abstract AND art".

Looking at the SQL that PO sends to the database, I could trace the error. The search above produces the SQL:

[...]
OR photo.identifier in (select k.photo from photo_keywords k where (k.keyword ~* 'abstract' and k.keyword ~* 'art'))
[...]

This seems to be wrong since k.keyword contains only ONE keyword at a time. So "k.keyword ~* 'abstract' and k.keyword ~* 'art'" will never find a corresponding line in the database.

The SQL-part about keywords should be

photo.identifier in(select k.photo from photo_keywords k where k.keyword ~* 'abstract') and photo.identifier in(select k.photo from photo_keywords k where k.keyword ~* 'art')

The "AND" must be between the two "in(select... )"-Subqueries, not in them.

The problem in the code is in search.text.general.php, line 160, where a string plus the build_sql_search_string-function are used to generate $sql_search_keyword. I would suggest to write a new function, which is the same as build_sql_search_string() exept the part that handles "AND". This should be something like:

elseif (strncmp($keyword[operator], "AND", 3) == 0) {
if ($sql_search_string == "")
$sql_search_string = "photo.identifier in (select k.photo from photo_keywords k where " .sprintf("%s %s", $sql_field_name, $keyword[keyword]);
else
$sql_search_string .= " and photo.identifier in (select k.photo from photo_keywords k where " .sprintf("%s %s", $sql_field_name, $keyword[keyword]).")";
}

In line 160 in search.text.general.php ")" should be added to the return of this new function at the end, but no text at the beginning.
That should fix the simple search.
I have not investigated into the complex search, which doesn't find keywords linked by "AND" either.

 183 Feature RequestHighBackend / Core Rip out "shopping" and everything associated with it. ClosedDevel1 Task Description

* There's a lot of it.
* I don't fully understand how it works.
* It's complicated and has internal dependencies all over the place.
* Does anyone really use it?
* The "client" distinction is flawed.

I want PO to be an organizational tool first, and any e-commerce bits need to be carefully thought out.

 193 Bug ReportHighBackend / Core figure out why e-mail templates are broken. ClosedDevel Task Description

They're not getting evaluated properly.

 240 Bug ReportHighBackend / Core "Empty trash" broken in r1539 ClosedDevel Task Description

"Empty trash" appears effectively broken now (Release trunk, r1539)

Whether in main listing, or in the Trash folder listing, the page appears to be blank.
In the error-file there is a notice:

Function name must be a string in /var/www/po.bugslayer.de/html/trash.empty.php on line 52, referer: http://po.bugslayer.de/folder.php?folder=1

Kind of showstopper :-O

 334 Bug ReportHighBackend / Core cannot delete users that have folder/album thumbnails s ...ClosedDevel4 Task Description

via the admin.user.del pages.

the problem is due to a dependency.

 389 Bug ReportHighBackend / Core cannot edit any photo Closed2.361 Task Description

When i try to edit any photo (click on album name, then the photo i want to edit, choose 'edit') - i.e. add keyword - after all the modifications are done, click on 'Save changes' and nothing appens. Reading the log i've found:
[error] [client 127.0.0.1] PHP Fatal error: Call to a member function delete() on a non-object in /var/www/html/po/photo.edit.2.php on line 175, referer: http://localhost/po/photo.edit.php?photo=1&album=

Tried on a fedora core 8 and debian testing (pgsql 8.2.9, php 5.2.6)

Thanks,
Giovanni

 435 Bug ReportHighBackend / Core Security problem: world readable files in /tmp (and may ...Closed2.363 Task Description

I've noticed that in various situations, Photo Organizer creates files in /tmp.
These have loose permissions due to an inadequate umask.

What's the point of Alice making her pictures private, so that Bob can't
see them, if Bob has a shell account on the box and can see Alice's
data as it passes through /tmp?

My /var/lib/photoorganizer-data directory behaves the same way.
Everything under that is rwxr-xr-x or rwxr--r--.

The data is correctly owned by the apache user account (www-data
in my installation) but files should should be rw-------,
and directories and rwx------.

Is this something that can be done globally with PHP or some Apache2
umask setting?

 439 Bug ReportHighBackend / Core photos not shown after update  Closed2.379 Task Description

Hi,

after update from 2.36 to 2.37 photos are not visible anymore.
The first try of update failed with an error at "DROP OPERATOR ||| (character varying, character varying)". Verifying the staetment on the command line show operator does not exist. After commenting out this line the update was succesfull (no error messages).
No errors are shown postgres or webserver log.

Different behaviour, depended if logged or not:
not logged in: only numbers of photos shown
logged in: after click on number a three available sizes are shown, click on one of them give : "Warning: ini_set() [ref.outcontrol]: Cannot change zlib.output_compression - headers already sent in /home/www/thyscom.ch/po/image.display.php on line 59" whcih is confusing - zlib is available and compress_pages is off

regards, Gerd
(www.thyscom.ch/po)

 62 Feature RequestMediumBackend / Core Rewrite installer to use *anything* other than tcsh ClosedStable6 Task Description

TCSH is a gawd-awful pile of crap, and the install script reflects that.

Code duplicated all over the place... yuck. No functions! Yuck! (And no, parameterized aliases don't really count..)

These days one is also more likely to have perl than tcsh installed..

 72 Bug ReportMediumBackend / Core Upload of rotated jpg images appear upside down Closed2.292 Task Description

When I upload a rotated jpg image from a Nikon D70, the image appears upside down. A sample photo has been uploaded to the demo 2.30 site under user mgoroff and folder "Test images" and it behaves the same as 2.29B. The first image in that folder was upside down when uploaded, but I used rotation to correct it. The second image is the same one not rotated and is upside down.

 86 Bug ReportMediumBackend / Core TYPO ALERT ClosedStable1 Task Description

even as I know less than nothing about PHP I think it won't manage this automagically.

You insist to include "config_site.php" at the end of include/config.php but there is only a "config_site.inc", two directory levels above.

Regards from the wise guy ;-)

 90 Bug ReportMediumBackend / Core Times are lost when editing an image's details. Closed2.31a2 Task Description

The 'Exposure date' thing strips the time off of the image when you click submit.

This is bad..

 92 Bug ReportMediumBackend / Core Adding a folder failed Closed2.31a5 Task Description

Warning: pg_query(): Query failed: ERROR: syntax error at or near ")" at character 224 in /home/www/doc/po/folder.add.2.php on line 56
Failed to create new folder: Limmat
Warning: Cannot modify header information - headers already sent by (output started at /home/www/doc/po/folder.add.2.php:56) in /home/www/doc/po/folder.add.2.php on line 67

System: Debian testing, Postgresql 7.4

 96 Bug ReportMediumBackend / Core Register a nnew user failed Closed2.31b2 Task Description

Version 2.31B (installer say 2.31C)

on login page "register", fill out username, password, confirm password, first name, last name, email, nothing else. "Register" ->

Error:

Warning: pg_query(): Query failed: ERROR: syntax error at or near "," at character 676 in /home/www/doc/po/register.php on line 202

Warning: pg_query(): Query failed: ERROR: current transaction is aborted, commands ignored until end of transaction block in /home/www/doc/po/register.php on line 209

Warning: pg_query(): Query failed: ERROR: current transaction is aborted, commands ignored until end of transaction block in /home/www/doc/po/register.php on line 216

Warning: pg_query(): Query failed: ERROR: current transaction is aborted, commands ignored until end of transaction block in /home/www/doc/po/register.php on line 224

Warning: pg_query(): Query failed: ERROR: current transaction is aborted, commands ignored until end of transaction block in /home/www/doc/po/register.php on line 230

Warning: pg_query(): Query failed: ERROR: current transaction is aborted, commands ignored until end of transaction block in /home/www/doc/po/register.php on line 234

Warning: pg_query(): Query failed: ERROR: current transaction is aborted, commands ignored until end of transaction block in /home/www/doc/po/register.php on line 238

Warning: Cannot modify header information - headers already sent by (output started at /home/www/doc/po/register.php:202) in /home/www/doc/po/register.php on line 254

best regards, Gerd

 109 Bug ReportMediumBackend / Core SQL error from tools.php Closed2.32b1 Task Description

As I still have "display errors on" in my php.ini. I can see this when going to the tools menu as a mere user.

Warning: pg_query() [function.pg-query]: Query failed: ERROR: syntax error at or near "group" at character 49 in /var/www/localhost/htdocs/po/include/tools.php on line 216

Warning: pg_num_rows(): supplied argument is not a valid PostgreSQL result resource in /var/www/localhost/htdocs/po/include/tools.php on line 217

 111 Feature RequestMediumBackend / Core Use PHP's builtin session support ClosedStable5 Task Description

The builtin session stuff, especially where shared logins are enabled, is rather kludgy.

I'd much rather use PHP's builtin session support, and eliminate PO's cobbled-together one-session-per-user nonsense.

 116 Bug ReportMediumBackend / Core GROUP is reserved word in PostgreSQL ClosedDevel1 Task Description

The new DDL for the permissions objects in the PENDING file include a column named "group". This is a reserved word in PosgreSQL and the code refuses to apply. I am using PostgreSQL 8.1.4 (with client 8.1.5) though according to the documentation it was reserved in 7.3 as well. http://www.postgresql.org/docs/7.3/static/sql-keywords-appendix.html

 136 Bug ReportMediumBackend / Core move to folder from folder view not working ClosedDevel Task Description

When attempting to move a number of photos from one folder to another in the folder view, it fails with no notification. (Aside from the fact that the photos haven't been moved.) I tracked it down to line 158 of folder.content.php. Very minor change.

See attached svn diff

 139 Bug ReportMediumBackend / Core Unable to logout ClosedStable Task Description

When clicking the Logout tab, you always get the login screen, even if you are already logged in. I traced this down to login.php. When you go to the login.php page from teh logout tab it does not set the "operation" parameter in the request. Therefore, at line 121 the elseif returns false (it is looking for operation==login) and the default else statement is displayed, which is a login.

There are tons of ways to get this fixed. I have included a diff which sets the operation value to "login" if it is not otherwise set. This causes the login page to check if there is a session and either display the login or logout page. I thought this was the best way as it was centralized.

The one other change in the diff is a change to remove a couple of tabs from the beginnings of lines since you seem to prefer spaces.

 197 Feature RequestMediumBackend / Core Add an option to ignore the "exif title" tag. Closed2.33
 198 Bug ReportMediumBackend / Core Bug in SQL functions count_equipment_by_user and number ...Closed2.33
 207 Bug ReportMediumBackend / Core ould not create new user entry, database error -- New i ...ClosedDevel25
 211 Bug ReportMediumBackend / Core Fields cannot be updated for a single picture ClosedDevel8
 228 Bug ReportMediumBackend / Core Cannot import NEF raw when orientation is portrait Closed2.34-rc18
 248 Bug ReportMediumBackend / Core Clear Keyword broken in bulk update Closed2.34-rc3
 260 Bug ReportMediumBackend / Core "Clear Keyword": Typo in "bulk.update.php" Closed2.34-rc3
 271 Bug ReportMediumBackend / Core PHP Timeout on bulk updates with watermarking Closed2.34-rc323
 322 Bug ReportMediumBackend / Core 'transfer metadata' isn't working for RAW images. Closed2.35
 332 Bug ReportMediumBackend / Core Cannot add album in 2.36dev (svn 1968) ClosedDevel2
 333 Bug ReportMediumBackend / Core Import does not work when exif "Focal Length" does not  ...ClosedDevel5
 370 Bug ReportMediumBackend / Core Can`t empty trash in v2.36-rc2 ClosedDevel2
 378 Bug ReportMediumBackend / Core not a bug, need a hint Closed2.364
 403 Bug ReportMediumBackend / Core profile.del.2.php missing when deleting camera from pro ...ClosedDevel1
 406 Feature RequestMediumBackend / Core resource password storing Closed2.363
440Bug ReportMediumBackend / CorePossible to set an album/folder's parent to itself.New2.37
 4 Feature RequestLowBackend / Core Hierarchical bulk Input Closed2.291
 5 Feature RequestLowBackend / Core Bulk update improvements ClosedDevel2
6Feature RequestLowBackend / CoreSpecify/store RAW image parametersNewDevel1
 7 Feature RequestLowBackend / Core Generate a hi-res JPEG from RAW images ClosedDevel11
8Feature RequestLowBackend / CoreBetter permission hierarchyAssignedDevel21
 10 Feature RequestLowBackend / Core Add generic key=value preference system ClosedDevel1
11Feature RequestLowBackend / CoreClean up database conventionsAssignedDevel6
 13 Feature RequestLowBackend / Core Rework spooling ClosedDevel5
 15 Feature RequestLowBackend / Core Offline export support ClosedDevel
Showing tasks 1 - 50 of 448 Page 1 of 9

Available keyboard shortcuts

Tasklist

Task Details

Task Editing