Photo Organizer

This is the bug tracker for Photo Organizer.
Tasklist

FS#433 - New location always added even exist

Attached to Project: Photo Organizer
Opened by Geoffrey Lee (geolee) - Wednesday, 09 June 2010, 12:37 GMT
Last edited by Solomon Peachy (pizza) - Thursday, 17 June 2010, 15:03 GMT
Task Type Bug Report
Category Backend / Core → Import
Status Closed
Assigned To No-one
Operating System All
Severity Low
Priority Normal
Reported Version Devel
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

In v2.37rc2 if you leave STATE blank when importing.
I need to comment out line 52 in include/iptc.php to disable redundant STATE check.
line 52 ( and location.state = state.identifier )
Is it logical to set it default? For example, if you took some photos from Bangkok, you will file it with CITY Bangkok, COUNTRY Thailand and leave STATE blank, you even don't know what to fill in STATE as a tourist.
This task depends upon

Closed by  Solomon Peachy (pizza)
Thursday, 17 June 2010, 15:03 GMT
Reason for closing:  Fixed
Comment by Solomon Peachy (pizza) - Thursday, 10 June 2010, 17:42 GMT
So it keeps creating location entries with a blank state field?

..can you attach an image that shows this problem so I can figure out exactly what's going wrong?
Comment by Geoffrey Lee (geolee) - Friday, 11 June 2010, 15:55 GMT
It wiill create new same location entry with new identifier when you import photo. ( same country, same city, blank state field )
Line 52 require the existing location match the state field of import photo has an entry in TABLE state, otherwise it fails 'existing location check', then it will create a new location entry. But it will always fail the query if state filed is blank since there is not an entry of NULL in TABLE state.

p.s. a sample image is attached.
   pool.jpg (128.6 KiB)
Comment by Solomon Peachy (pizza) - Thursday, 17 June 2010, 15:03 GMT

Loading...