Photo Organizer

Notice: Undefined index: tasklist_type in /var/www/flyspray/includes/class.tpl.php(128) : eval()'d code on line 85 Notice: Undefined index: tasklist_type in /var/www/flyspray/includes/class.tpl.php(128) : eval()'d code on line 90
  • Status Closed
  • Percent Complete
    100%
  • Task Type Bug Report
  • Category Backend / Core → Import
  • Assigned To No-one
  • Operating System All
  • Severity Low
  • Priority Normal
  • Reported Version Devel
  • Due in Version Undecided
  • Due Date Undecided
  • Votes 0
  • Private No
Attached to Project: Photo Organizer
Opened by Geoffrey Lee (geolee) - 2010-06-09
Last edited by Solomon Peachy (pizza) - 2010-06-17

FS#433 - New location always added even exist

In v2.37rc2 if you leave STATE blank when importing.
I need to comment out line 52 in include/iptc.php to disable redundant STATE check.
line 52 ( and location.state = state.identifier )
Is it logical to set it default? For example, if you took some photos from Bangkok, you will file it with CITY Bangkok, COUNTRY Thailand and leave STATE blank, you even don't know what to fill in STATE as a tourist.

This task does not depend on any other tasks.

Closed by  Solomon Peachy (pizza)
Thursday, 17 June 2010, 15:03 GMT
Reason for closing:  Fixed
Solomon Peachy (pizza)
Thursday, 10 June 2010, 17:42 GMT
So it keeps creating location entries with a blank state field?

..can you attach an image that shows this problem so I can figure out exactly what's going wrong?
Geoffrey Lee (geolee)
Friday, 11 June 2010, 15:55 GMT
It wiill create new same location entry with new identifier when you import photo. ( same country, same city, blank state field )
Line 52 require the existing location match the state field of import photo has an entry in TABLE state, otherwise it fails 'existing location check', then it will create a new location entry. But it will always fail the query if state filed is blank since there is not an entry of NULL in TABLE state.

p.s. a sample image is attached.
   pool.jpg (128.6 KiB)

Loading...