Photo Organizer

  • Status Closed
  • Percent Complete
  • Task Type Bug Report
  • Category Backend / Core → Import
  • Assigned To No-one
  • Operating System All
  • Severity Low
  • Priority Very Low
  • Reported Version Devel
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Photo Organizer
Opened by Geoffrey Lee - 2010-06-09
Last edited by Solomon Peachy - 2010-06-17

FS#433 - New location always added even exist

In v2.37rc2 if you leave STATE blank when importing.
I need to comment out line 52 in include/iptc.php to disable redundant STATE check.
line 52 ( and location.state = state.identifier )
Is it logical to set it default? For example, if you took some photos from Bangkok, you will file it with CITY Bangkok, COUNTRY Thailand and leave STATE blank, you even don't know what to fill in STATE as a tourist.

Closed by  Solomon Peachy
2010-06-17 15:03
Reason for closing:  Fixed
Solomon Peachy commented on 2010-06-10 17:42

So it keeps creating location entries with a blank state field?

..can you attach an image that shows this problem so I can figure out exactly what's going wrong?

Geoffrey Lee commented on 2010-06-11 15:55

It wiill create new same location entry with new identifier when you import photo. ( same country, same city, blank state field )
Line 52 require the existing location match the state field of import photo has an entry in TABLE state, otherwise it fails 'existing location check', then it will create a new location entry. But it will always fail the query if state filed is blank since there is not an entry of NULL in TABLE state.

p.s. a sample image is attached.

   pool.jpg (128.6 KiB)
Solomon Peachy commented on 2010-06-17 15:03

Okay, it's now fixed. Here's the patch:;a=commitdiff_plain;h=0ab352e7f15a7a5dea72186aecec107f17f5b19c


Available keyboard shortcuts


Task Details

Task Editing