Photo Organizer

This is the bug tracker for Photo Organizer.
Tasklist

FS#348 - Photo location

Attached to Project: Photo Organizer
Opened by Marcus Hinz (marcus) - Sunday, 20 April 2008, 19:44 GMT
Last edited by Solomon Peachy (pizza) - Monday, 21 April 2008, 12:32 GMT
Task Type Bug Report
Category Backend / Core
Status Closed
Assigned To No-one
Operating System All
Severity Low
Priority Normal
Reported Version 2.35
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

I dont' know if this is a feature or a bug. I try to explain my problem:

My geotagged photos contain the country, the province, the city and the sublocation in the IPTC data. In the location of MyProfile and in the location of photo details the sub-location is not shown. Is this correct?

Marcus

PS: Many thanks for implementating #337!
This task depends upon

Closed by  Solomon Peachy (pizza)
Monday, 21 April 2008, 12:32 GMT
Reason for closing:  Fixed
Additional comments about closing:  r2011 has the fix to the fix.
Comment by Solomon Peachy (pizza) - Monday, 21 April 2008, 00:34 GMT
That sounds like the IPTC import isn't getting the sublocation properly. Can you send me an image so I can test things out myself?
Comment by Solomon Peachy (pizza) - Monday, 21 April 2008, 00:42 GMT
Yeah, the IPTC code is ignoring the 'Sub-Location' field altogether. Apparently it's been that way all along.
Comment by Solomon Peachy (pizza) - Monday, 21 April 2008, 01:07 GMT
I've attached a patch -- committed in r2010. I can't promise it'll work as I don't have anything to test it against.

All current 'locations' that were created are all missing their sub-location, so you'll need to fix them up and/or re-import the images so the IPTC sub-location gets picked up properly. (Or hack something together that re-parses the IPTC stuff. I've done this sort of thing many times before...)

Let me know how it works. I've updated the demo sites (-stable and -devel) with this fix.
   fix.diff (2.3 KiB)
Comment by Marcus Hinz (marcus) - Monday, 21 April 2008, 06:44 GMT
Now it works!

But there's a mistake in common.php. Your stable demo site doesn't run anymore. I think the attached patch could fix it.
   common.diff (0.9 KiB)
Comment by Solomon Peachy (pizza) - Monday, 21 April 2008, 12:32 GMT
It's obvious I didn't test it, yeah. But I must have accidentally committed (and sent off) and older version of the patch instead of what I'd applied to the -devel tree.

Thanks for the fix. :)

Loading...