Photo Organizer

This is the bug tracker for Photo Organizer.
Tasklist

FS#288 - Preferences in photo upload

Attached to Project: Photo Organizer
Opened by Marcus Hinz (marcus) - Saturday, 01 September 2007, 07:15 GMT
Last edited by Solomon Peachy (pizza) - Sunday, 02 September 2007, 17:44 GMT
Task Type Bug Report
Category Backend / Core
Status Closed
Assigned To No-one
Operating System All
Severity Low
Priority Normal
Reported Version 2.34-rc4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

The preferences in "My Setting - Photo upload" (gamma, sharpen radius etc.) are not working correctly in german translation. I think the reason is the decimal-delimter (1,5 in German - 1.5 in US).
This task depends upon

Closed by  Solomon Peachy (pizza)
Sunday, 02 September 2007, 17:44 GMT
Reason for closing:  Fixed
Additional comments about closing:  ...
Comment by Solomon Peachy (pizza) - Saturday, 01 September 2007, 11:54 GMT
@$^@!!

Why, oh why isn't there a simple way to ignore locale settings?

I think I got all cases where we pass floatings point numbers to external applications; r1662 has the last commit.

I won't be able to test this personally for a few hours, so please let me know if it works...
Comment by Marcus Hinz (marcus) - Saturday, 01 September 2007, 12:42 GMT
Sorry, it still doesn't work correctly. If I for example choose "1.5" for gamma in photo upload settings and save it, the value changes to "2.2" automatically. Maybe the right value is passed to the external application.

The same problem exists for "sharpen radius", "Brightness (dcraw)", "Gamma (ufraw)" and "Gamma linearity"
Comment by Solomon Peachy (pizza) - Saturday, 01 September 2007, 14:18 GMT
Ah, I was misunderstanding what the problem was.. but I ended up fixing the next step in the chain anyway.

I'll see what I can figure out.
Comment by Solomon Peachy (pizza) - Saturday, 01 September 2007, 16:22 GMT
I think I got it this time.

I had to disable the use of locale-specific number formatting altogether, and instead convert as needed. There are places where the output needs to be fixed up (eg aperture) but I'd rather have "misformat" instead of "notwork"..

Please test and let me know if it works for you.
Comment by Marcus Hinz (marcus) - Saturday, 01 September 2007, 16:43 GMT
Good job!!! Now it works for me. Thank you!

Loading...