- Status Closed
- Percent Complete
- Task Type Bug Report
- Category Backend / Core
-
Assigned To
pizza - Operating System All
- Severity High
- Priority Very Low
- Reported Version Devel
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#18 - Stop using predictable filenames
For things like photo imports, exports, and whatnot, we use predictable sequences in our filenames. These should be properly randomized.
Closed by pizza
2006-06-06 21:05
Reason for closing: Implemented
Additional comments about closing: imports, exports, and raw processing all using much safer temporary names. Still some race conditions present, but unfortunately PHP limitations make these impossible to completely eliminate.
2006-06-06 21:05
Reason for closing: Implemented
Additional comments about closing: imports, exports, and raw processing all using much safer temporary names. Still some race conditions present, but unfortunately PHP limitations make these impossible to completely eliminate.
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
-devel uses tempnam() for the intermediate PPM part in raw decodes, but it has a race condition caused by needing to rename the random filename to $filename.ppm. It's still an improvement over -stable, however.
Meanwhile, the photo import and photo export are both unsafe, as they use a serialized directory name.
Fixed the intermediate PPM stuff in -STABLE, r362
Safe bulk import directory creation, r363(stable), r365(devel)
Safe export support. r370 -devel, r371 -stable.