Photo Organizer

Notice: Undefined index: tasklist_type in /var/www/flyspray/includes/class.tpl.php(128) : eval()'d code on line 85 Notice: Undefined index: tasklist_type in /var/www/flyspray/includes/class.tpl.php(128) : eval()'d code on line 90
  • Status Closed
  • Percent Complete
  • Task Type Feature Request
  • Category Backend / Core
  • Assigned To No-one
  • Operating System All
  • Severity Low
  • Priority Normal
  • Reported Version 2.32b
  • Due in Version Undecided
  • Due Date Undecided
  • Votes 0
  • Private No
Attached to Project: Photo Organizer
Opened by Luud Heck (Luud) - 2006-11-21
Last edited by Solomon Peachy (pizza) - 2007-07-24

FS#120 - Allow selection and export of other user's photos

In my current setup, it is not possible to select photos when browsing an other user's photos. Therefore it also not possible to download these selected photos in one go. It would be great if such a setting could be enabled, maybe on a per user setting. For me a global flag to enable this would suffice at the moment.

This task does not depend on any other tasks.

Closed by  Solomon Peachy (pizza)
Tuesday, 24 July 2007, 12:47 GMT
Reason for closing:  Implemented
Additional comments about closing:  I actually implemented this a couple of weeks ago, forgetting there was actually a bug ticket about it.

Any photo that the user can see can be spooled (and added to one of their albums), and if they can get the high-res original, they can export it too.
Solomon Peachy (pizza)
Tuesday, 21 November 2006, 15:32 GMT
Hmm..... I like it, but it has some interesting security implications.

I guess in the shorter term we could only allow checkboxes on images that have originals accessible; but we'd need to ensure we only allow those to be exported, not mangled in other ways (right now it's all-or-nothing).

(Although, as I write this, one could hand-craft a request that could do just what you ask because ownership isn't being properly checked on the the pages that process user selections -- but that will be fixed before v2.33 is released)
Luud Heck (Luud)
Wednesday, 22 November 2006, 08:48 GMT

This sounds like a call for better separation between functionality and permission control. Good to know that work in that area is already being done.

At the moment I would accept a global flag in config.php that would enable users to select and export photos from other users. The default could be off, like the local bulk upload.
Solomon Peachy (pizza)
Friday, 24 November 2006, 14:12 GMT
believe it or not, I needed this feature late last night. Right now it's admin-only, and only in the devel tree, which already had very different code for the spool and handling checkboxes etc.

I'll backport what I can, but it might not be possible until I backport the spool and new checkbox code, which is definately post-2.33.
Solomon Peachy (pizza)
Friday, 24 November 2006, 14:33 GMT
As the code is right now, "clients" don't have access -- but they should.

We really do need this to work for all images in which the viewer can access the original, but that particular interaction is far to complex to cut-n-paste everywhere.